Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: vf-form__core references sass files from other components #397

Merged
merged 2 commits into from Jun 6, 2019

Conversation

khawkins98
Copy link
Contributor

@khawkins98 khawkins98 commented Jun 6, 2019

This was throwing up errors when just vf-form was in a project (which is installed by vf-content)

@auto-comment
Copy link

auto-comment bot commented Jun 6, 2019

Thank you for requesting a review for this pull request (PR).
If this PR has an associated issue - please add that to the PR description.
If you have not done so already - please fill out the PR description with as much context as possible.

@auto-comment
Copy link

auto-comment bot commented Jun 6, 2019

Have you added any relevant labels to this PR?
To help this process please make sure you have these things ready (if applicable).

  • package.json updated accordingly. - [ ] README.md fill out with required documentation. - [ ] any .scss files correctly documented. - [ ] a detailed outlin on what this PR is expected to do

@khawkins98 khawkins98 merged commit 1278010 into develop Jun 6, 2019
@khawkins98 khawkins98 deleted the fix/vf-form branch June 6, 2019 10:10
@khawkins98 khawkins98 mentioned this pull request Jun 18, 2019
7 tasks
@khawkins98 khawkins98 added this to the v2.0.0-alpha.6 milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants