Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT - Mobile placement of press contact, other boxes #349

Open
khawkins98 opened this issue Jun 11, 2020 · 3 comments
Open

ENHANCEMENT - Mobile placement of press contact, other boxes #349

khawkins98 opened this issue Jun 11, 2020 · 3 comments
Labels
enhancement New feature or request Low Priority: Low

Comments

@khawkins98
Copy link
Contributor

Noticed this while reading a news post on my phone: https://www.embl.org/news/science/new-insights-into-epigenetic-modifications/

image

It would be better if the "Press contact" box appeared lower on the mobile phone (bottom of post).

There are two "typical" methods to do this:

  1. Add some kind of push/pull source ordering support to make left column show on the bottom on the mobile (this would also move the author info to the bottom)
  2. Add the "press contact" a second time in the HTML, appearing at the bottom. Use CSS to show/hide accordingly, i.e.vf-u-grid--hide-for-small
  3. Or, dodge it for now, and move the "Press contact" to the right

This will probably bubble up into some things for vf-core, but starting the journey here.

@khawkins98 khawkins98 added enhancement New feature or request Low Priority: Low labels Jun 11, 2020
@sturobson
Copy link

  1. drop the custom class article-left-col to the bottom using:

As there's 'no grid' on mobile we can use display: flex; up to the viewport size the grid kicks in.

@media (max-width: 1023px) {
  .embl-grid {
    display: flex;
    flex-direction: column;
  }
  .article-left-col {
    order: 2;
  } 
}


*notes:* doing this will effect all `embl-grid`s at these viewports - can we create something like `embl__news-article` on the body to hook into?

@sturobson
Copy link

sturobson commented Jun 11, 2020

asides:

  • to me it's weird having the press contact information there and not at the bottom?
  • should we be asking readers to share an article at the top of a page, before they'd potentially read it?
  • would the author details be better placed after the headline? So we just have a single column of content?

This (image below) looks incredibly busy compared to our 'containerisation' of the rest of the site designs.

Screenshot 2020-06-11 at 10 20 27

@sturobson
Copy link

related:

on - https://wwwdev.embl.org/groups/chemical-biology/ - the contact information is on the right.

Should we aim for some consistency betwixt the two too?

Screenshot 2020-06-15 at 09 36 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants