Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo logo #18

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Repo logo #18

wants to merge 8 commits into from

Conversation

eyerusalemdani
Copy link
Collaborator

repo logo

@eyerusalemdani eyerusalemdani added the enhancement New feature or request label Aug 9, 2022
@wandyezj
Copy link
Contributor

wandyezj commented Aug 9, 2022

Why is there a vscodeLogo folder in this PR 18 and a logo folder in PR 17?

@wandyezj
Copy link
Contributor

wandyezj commented Aug 9, 2022

What is the generate.cmd for? What is it used for?

set THISDIR=%THISDIR:~,-1%

rem inkscape program path
set inkscape="%tools%\Programs\inkscape\inkscape.exe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get this to work:

  1. Install inkscape
  2. Replace "%tools%\Programs\inkscape\inkscape.exe" with the location inkscape on your machine.

@Majd223 Majd223 linked an issue Aug 10, 2022 that may be closed by this pull request
@eyerusalemdani
Copy link
Collaborator Author

Why is there a vscodeLogo folder in this PR 18 and a logo folder in PR 17?

Fixed.

Copy link
Contributor

@Eftu-Wakjira Eftu-Wakjira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

package.json Outdated
@@ -23,9 +23,9 @@
"id": "myextension.largeNumberBackground",
"description": "Background decoration color for large numbers",
"defaults": {
"dark": "#FF000055",
"light": "#FF000055",
"highContrast": "#FF000055"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't have changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as package.json and package-lock.json

@Eftu-Wakjira Eftu-Wakjira self-requested a review August 16, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logo for repository (handmade)
4 participants