Skip to content

Commit

Permalink
Codesign fix for mac.
Browse files Browse the repository at this point in the history
Followup on 07064c8.

Use codesign --deep to sign the .app before signing all the frameworks,
otherwise codesign will refuse to sign the app due to unsigned dylibs
when not making a static build.

The error is:

./visualboyadvance-m.app: code object is not signed at all
In subcomponent: ...libtheoraenc.1.dylib

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
  • Loading branch information
rkitover committed May 8, 2020
1 parent 07064c8 commit 1bced47
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/wx/CMakeLists.txt
Expand Up @@ -1222,7 +1222,7 @@ if(APPLE AND (UPSTREAM_RELEASE OR ENABLE_ONLINEUPDATES))
add_custom_command(
TARGET visualboyadvance-m
POST_BUILD
COMMAND codesign --sign "Developer ID Application" --force ./visualboyadvance-m.app
COMMAND codesign --sign "Developer ID Application" --force --deep ./visualboyadvance-m.app
WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
)

Expand Down

0 comments on commit 1bced47

Please sign in to comment.