Skip to content

Commit

Permalink
builder: more minor mingw cross fixes
Browse files Browse the repository at this point in the history
Do not defer evaluating build env variables in mingw-cross.sh, this
interferes with switching them between host/target.

In build_dist() adjust the LDFLAGS and LIBS after pre_build has run,
because host/target env setting happens in pre_build and adjustments get
lost.
  • Loading branch information
rkitover committed Nov 12, 2018
1 parent d725978 commit a3ec309
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions tools/builder/core.sh
Expand Up @@ -1336,6 +1336,9 @@ build_dist() {

puts "${NL}Building $current_dist${NL}${NL}"

dist_patch "$current_dist"
dist_pre_build "$current_dist"

ORIG_LDFLAGS=$LDFLAGS
ORIG_LIBS=$LIBS

Expand All @@ -1348,9 +1351,6 @@ build_dist() {
export LDFLAGS="$LDFLAGS $(eval puts "$(dist_extra_ldflags "$current_dist")")"
export LIBS="$LIBS $(eval puts "$(dist_extra_libs "$current_dist")")"

dist_patch "$current_dist"
dist_pre_build "$current_dist"

configure_override=$(dist_configure_override "$current_dist")
install_override=$(dist_install_override "$current_dist")
build_override=$(dist_build_override "$current_dist")
Expand Down
10 changes: 5 additions & 5 deletions tools/builder/mingw-cross.sh
Expand Up @@ -46,11 +46,11 @@ export CC='${target_arch}-gcc'
export CXX='${target_arch}-g++'
export STRIP='${target_arch}-strip'
export CPPFLAGS="\$CPPFLAGS"
export CFLAGS="\$CFLAGS\${CFLAGS:+ }-L/usr/${target_arch}/usr/lib${lib_suffix}"
export CXXFLAGS="\$CXXFLAGS\${CXXFLAGS:+ }-L/usr/${target_arch}/usr/lib${lib_suffix}"
export OBJCXXFLAGS="\$OBJCXXFLAGS\${OBJCXXFLAGS:+ }-L/usr/${target_arch}/usr/lib${lib_suffix}"
export LDFLAGS="-L/usr/${target_arch}/usr/lib${lib_suffix} \$LDFLAGS"
export CPPFLAGS="$CPPFLAGS"
export CFLAGS="$CFLAGS${CFLAGS:+ }-L/usr/${target_arch}/usr/lib${lib_suffix}"
export CXXFLAGS="$CXXFLAGS${CXXFLAGS:+ }-L/usr/${target_arch}/usr/lib${lib_suffix}"
export OBJCXXFLAGS="$OBJCXXFLAGS${OBJCXXFLAGS:+ }-L/usr/${target_arch}/usr/lib${lib_suffix}"
export LDFLAGS="-L/usr/${target_arch}/usr/lib${lib_suffix} $LDFLAGS"
EOF
)
Expand Down

0 comments on commit a3ec309

Please sign in to comment.