Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the Escape key's default function might be a good idea. #298

Open
ShadowDragon8685 opened this issue Aug 5, 2018 · 6 comments
Open
Assignees
Labels

Comments

@ShadowDragon8685
Copy link

ShadowDragon8685 commented Aug 5, 2018

Expected behavior

In most video games released anytime in the last two decades or so, the Escape key brings up a menu of some description or another, and its usage as such is a deeply-ingrained instinct in gamers.

In most non-videogame programs, pressing escape does nothing.

Actual behavior

In VBAM, in default keybinds, the Escape button immediately and without prompt kills the program.

Steps to reproduce the behavior

Open VBAM with default settings, load a game, (for maximum impact load an RPG of some description,) play for 2-3 hours, desire to do something else and to save your progress before doing so, and press escape out of muscle memory intending to save your game. Watch as your progress is immediately lost. (Swearing at this point is optional, but may prove to be of some cathartic value.)

@ghost
Copy link

ghost commented Aug 6, 2018

you can actually re-assign the hotkey to whatever you want. but there's currently issue with regards to hotkeys. one is that the new hotkeys are not saved(try deleting hotkeys for quit. the next time vbam-is run the original hotkeys are returned), and on some systems, or installations hotkeys does not work(for example initially i reported hotkeys not working in tumbleweed, but recent recompilations seems to remedied it somehow for no clear reasons and its working for most parts...)

@ShadowDragon8685
Copy link
Author

Oh, I know you can, but as I said; the problem is that the default setting for the escape key does something that is practically the exact opposite of what every videogame I've played in the last twenty years has programmed into me: that Escape = Menu.

Even if Escape did nothing, it wouldn't be terribly bad, because all it takes is one or two presses of Escape to remember "Oh shit, I'm playing an emulator, the in-game menu is [whatever I've assigned the Start button to] and the emulator menus are standard Windows menu bar options I can click on," but that realization is way too little, far too late, if the programmed muscle-memory stab of escape causes the program to terminate without any warning, thus killing any progress I've made.

And I would be using savestates frequently and often, but experience has taught me that, especially with certain emulated games, this is setting myself up for a slow-burn corruption that will become inevitably unplayable but which finding an old-enough save to have averted the disaster might as well be starting anew anyway.

@rkitover rkitover self-assigned this Aug 6, 2018
@rkitover rkitover added the bug label Aug 6, 2018
@rkitover
Copy link
Collaborator

rkitover commented Aug 6, 2018

I looked at this before but couldn't find where the escape key was mapped, I'll try to take a look again and remove the mapping by default.

@ShadowDragon8685
Copy link
Author

I don't know if this helps you, but in VBAM itself, you can find the binds by going to Options -> Key Shortcuts -> File -> Quit, where it has a number of default keybinds, which rather frustratingly seem to rebind themselves to the defaults if you vacate those binds.

@rkitover
Copy link
Collaborator

rkitover commented Jan 5, 2019

Related: #334

rkitover added a commit that referenced this issue Jan 5, 2019
Remove esc to quit key bind #298.

Remove ctrl+x (cmd+x on mac) to quit key bind #334.

Remove FilterEvent app method, it is no longer being used anyway as key binds
work correctly.
@rkitover
Copy link
Collaborator

rkitover commented Jan 5, 2019

Fixed in master finally.

@rkitover rkitover added the fixed label Jan 5, 2019
@rkitover rkitover removed the fixed label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants