New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game screen off-center while in fullscreen #325
Comments
confirmed issue in linux as well |
Also confirming this issue on Windows 8.1. Games used for testing were: |
Add wxEXPAND spacers to frame wxBoxSizer on the top and bottom around the drawing panel so that panel is correctly centered if maximum zoom is set. Set proportion to 1 on the spacers and 0 on the panel so that both centering with maximum zoom and full expansion work correctly. Refactor frame OnSize event: pass a dummy userdata pointer to distinguish resizing the frame from resizing the panel, and call Layout() when the frame is resized. Signed-off-by: Rafael Kitover <rkitover@gmail.com>
Fixed in master. |
Here's a binary that has this fixed if anyone needs: |
On wxWidgets 3.1.2, which is what vcpkg uses (and we use vcpkg for Visual Studio) the wxEXPAND flag for the game area in the sizer throws an XRC error dialog, removing the flag works correctly on Windows, but not on wxGTK. As a workaround, do not use the wxEXPAND flag on Windows. TODO: with max zoom set, the game area is not centered vertically in wxGTK. Signed-off-by: Rafael Kitover <rkitover@gmail.com>
This is not quite ideal yet, it works correctly on Windows but for wxGTK the game area is not centered vertically. |
This and related geometry/sizing issues should all mostly be fixed in v2.1.3. |
Expected behavior
Game screen is correctly centralized while in fullscreen (x3 magnification)
Actual behavior
Game screen is grossly off-center (Top-center or upper-left) & cannot be adjusted while in fullscreen
Steps to reproduce the behavior
ROM details
Pokemon Blue (SGB)
GB games affected
Option details
OpenGL
XAudio
Build details
V 2.1
Windows 7
The text was updated successfully, but these errors were encountered: