Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game screen off-center while in fullscreen #325

Closed
SvSlazer18 opened this issue Nov 26, 2018 · 6 comments
Assignees
Labels

Comments

@SvSlazer18
Copy link

@SvSlazer18 SvSlazer18 commented Nov 26, 2018

Expected behavior

Game screen is correctly centralized while in fullscreen (x3 magnification)

Actual behavior

Game screen is grossly off-center (Top-center or upper-left) & cannot be adjusted while in fullscreen

Steps to reproduce the behavior

  1. Run the latest build (V 2.1 as of writing)
  2. Limit maximum magnification to x3 (May be reproducible with other settings)
  3. Load any game & engage fullscreen (GB games affected)

ROM details

Pokemon Blue (SGB)
GB games affected

Option details

OpenGL
XAudio

Build details

V 2.1
Windows 7

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Dec 23, 2018

confirmed issue in linux as well

@84L7H13R

This comment has been minimized.

Copy link

@84L7H13R 84L7H13R commented Jan 20, 2019

Also confirming this issue on Windows 8.1. Games used for testing were:
Mario Golf USA version for GB Color
Mario Golf Advance Tour USA version for GB Advance

@rkitover rkitover self-assigned this Jan 31, 2019
@rkitover rkitover added the UI label Jan 31, 2019
rkitover added a commit that referenced this issue Jan 31, 2019
Add wxEXPAND spacers to frame wxBoxSizer on the top and bottom around
the drawing panel so that panel is correctly centered if maximum zoom is
set.

Set proportion to 1 on the spacers and 0 on the panel so that both
centering with maximum zoom and full expansion work correctly.

Refactor frame OnSize event: pass a dummy userdata pointer to
distinguish resizing the frame from resizing the panel, and call
Layout() when the frame is resized.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
@rkitover rkitover added the fixed label Jan 31, 2019
@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jan 31, 2019

Fixed in master.

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Feb 3, 2019

Here's a binary that has this fixed if anyone needs:

visualboyadvance-m.zip

rkitover added a commit that referenced this issue Mar 22, 2019
On wxWidgets 3.1.2, which is what vcpkg uses (and we use vcpkg for
Visual Studio) the wxEXPAND flag for the game area in the sizer throws
an XRC error dialog, removing the flag works correctly on Windows, but
not on wxGTK.

As a workaround, do not use the wxEXPAND flag on Windows.

TODO: with max zoom set, the game area is not centered vertically in
wxGTK.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
@rkitover rkitover added partially fixed and removed fixed labels Mar 22, 2019
@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Mar 22, 2019

This is not quite ideal yet, it works correctly on Windows but for wxGTK the game area is not centered vertically.

@rkitover rkitover added fixed and removed partially fixed labels Apr 19, 2019
@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Apr 19, 2019

This and related geometry/sizing issues should all mostly be fixed in v2.1.3.

@rkitover rkitover closed this Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.