Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator freezes without access to Internet. #71

Closed
edorax opened this issue Feb 11, 2017 · 3 comments
Closed

Emulator freezes without access to Internet. #71

edorax opened this issue Feb 11, 2017 · 3 comments
Labels

Comments

@edorax
Copy link
Contributor

@edorax edorax commented Feb 11, 2017

Please fill out this form:

Expected behavior

It doesn't freeze.

Actual behavior

If there's no access to the Internet, the emulator freezes after the main window appears at startup.

Steps to reproduce the behavior

On Windows:
Disable the NIC or simple unplug the wire, then run the emulator.

void GameArea::OnIdle(wxIdleEvent& event)
{
...
// Check for online updates
if (gopts.onlineupdates > 0 && !emusys) {
// stuck here
-> wxGetApp().frame->CheckForUpdates();
}
...
}

Build details

  1. Setup the build system of MXE with:
    https://github.com/visualboyadvance-m/mxe
    Installed package needed by vba-m in MXE: wxwidgets, sdl2 he sfml, etc.
    Preppend the directory of usr/bin of MXE to the PATH env var.
  2. Pull the vba-m source from this Git repo:
    git clone https://github.com/visualboyadvance-m/visualboyadvance-m.git
  3. Create makefile:
    unset env | grep -vP '^\t' | grep -vi '^EDITOR=\|^HOME=\|^LANG=\|MXE\|^PATH=' | grep -vi 'PKG_CONFIG\|PROXY\|^PS1=\|^TERM=' | cut -d '=' -f1 | tr '\n' ' '
    BUILD_DIR=build-vbam-mxe
    rm -rf ${BUILD_DIR}
    && mkdir ${BUILD_DIR}
    && cd ${BUILD_DIR}
    && i686-w64-mingw32.static-cmake
    ../vba-m/visualboyadvance-m
  4. Make it:
    make -C ${BUILD_DIR}

Operating System (Windows, Mac, Linux, etc.):
Host OS: Ubuntu 16.04 LTS (64bit)
Target OS: Windows 7 (64bit)

Interface (wx, SDL, default is wx):
Is wx.

Version of code (pre-built binary version, or commit ref, or just "master"):
master

Any other relevant build information:

If this is e.g. a joystick or video issue, then the relevant hardware information:

@ZachBacon

This comment has been minimized.

Copy link
Contributor

@ZachBacon ZachBacon commented Feb 11, 2017

The issue is known and will be changed eventually. Will keep this up anyways.

rkitover added a commit that referenced this issue Feb 12, 2017
Remove the "check for updates" and "Update ROM database" menu entries,
as well as the automatic update checking and all supporting code.

This fixes the issue with the emulator hanging without access to the
internet.

Updating code will be reimplemented in the future using something like
Sparkle. wxHTTP does not support redirects or https so is pretty much
useless now.

Also update the About box to bump copyright year to 2017 and change my
name to "rkitover", which is what I use on github, and mention other
contributors.
@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Feb 12, 2017

Fixed in a493e0f.

We need to reimplement the executable updating and ROM database updating using something like Sparkle at some point.

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Feb 12, 2017

@edorax btw, on Ubuntu you can use:

./installdeps win32

to install all MXE deps automatically.

@rkitover rkitover closed this Feb 13, 2017
rkitover pushed a commit that referenced this issue Aug 15, 2019
Update Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.