Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMBN2 Chinese Translation stucks on opening menu, and a request #889

Closed
Yave-Yu opened this issue Oct 24, 2021 · 11 comments
Closed

MMBN2 Chinese Translation stucks on opening menu, and a request #889

Yave-Yu opened this issue Oct 24, 2021 · 11 comments
Assignees

Comments

@Yave-Yu
Copy link

Yave-Yu commented Oct 24, 2021

Version: 2.1.4-173512f6
Issue: In Mega Man Battle Network 2 (aka Rockman EXE 2) Chinese Translation, when you can control Lan then press start key, the game freezes, but it won't freeze in mGBA so I guess it's an emulation issue.
Could you look and fix it? Thanks!
Here's patch, apply it onto MMBN2 US ROM.
MMBN2CnTran.zip

Request: Can you make Noise channel louder? Current some music can't hear its noise drum clearly (most on MMBN series). Fun fact: an FB2K GSF plugin uses your VBA-M core but made noise channel louder, so I guess VBA-M itself could do this too.

@Squall-Leonhart
Copy link
Collaborator

use sdl, directsound or openal for louder noise channel

@Squall-Leonhart
Copy link
Collaborator

unknown 1

@Yave-Yu
Copy link
Author

Yave-Yu commented Oct 25, 2021

use sdl, directsound or openal for louder noise channel

Options -> Audio -> Configure ? I tried, Channel 4 (Noise channel) seems no change... No only this, but also cause PSG audio silent after change a device unless reload ROM.
(Actually SDL is default option)

@Squall-Leonhart
Copy link
Collaborator

@endrift i tried (and failed) to get the mgba logger to print thumb instructions that are fired when the player opens the main menu with this rom hack, but noticed your 2015 commit @ mgba-emu/mgba@b67e4b5

Are we missing these?

@endrift
Copy link

endrift commented Oct 25, 2021

image

Here's what the manual says about that opcode.

@Squall-Leonhart
Copy link
Collaborator

I have more or less a copy paste implementation in Squall-Leonhart@c85407b that seems to do the job of running the game, it could be wrong as all heck @endrift im not a core programmer and have no idea how to turn documentation into emulator code lmao

@Squall-Leonhart
Copy link
Collaborator

@Yave-Yu here is a test build
visualboyadvance-m.zip

@Yave-Yu
Copy link
Author

Yave-Yu commented Oct 25, 2021

Yeah, it won't freeze now, but then graphical bug discovered.

(Left is VBA-M, right is mGBA)
MMBN2_01
See text at right-bottom, seems palette gets wrong.

MMBN2_02
Text at left gets not only wrong palette but also weird background color.

MMBN2_03
"Function" text same as above.

@Squall-Leonhart
Copy link
Collaborator

not sure if thats due to my half arsed CMP3 implementation, probably is.

we do not have anyone that speaks arm/thumb on the team, let alone someone that can implement it to x86 asm, like it is.

@Steelskin
Copy link
Collaborator

I have a potential fix in 24b6ac5.

@Steelskin
Copy link
Collaborator

I tested the fix and can confirm that the graphical glitches are no longer present. I'll land the fix and close this. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants