Add LLDB support to gdb remote debugging stub #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the packet passed into remotePutPacket was 1024 bytes or larger then the buffer array would not be large enough to hold the $, checksum and zero byte written. This now allocates a buffer of size count + 5 to accommodate these extra characters.
When doing a remote memory read the debugger can ask for any size. The buffer being allocated however was only 1024 bytes long and the code in remoteMemoryRead also attempts to write a zero byte at the end of the array. This code will now take the count of bytes the debugger is trying to read and allocates a buffer that is count * 2 + 1 large. This is large enough to hold the $02x formatted hex byte for each byte as well as the zero byte written at the end.
https://github.com/llvm-mirror/lldb/blob/master/docs/lldb-gdb-remote.txt The qHostInfo command is listed as a high priority to implement for gdb stubs that lldb can connect to. Adding support for this command allows lldb to properly connect with it's `gdb-remote 55555` command and correctly determine the target and allow debugging.
knightsc
force-pushed
the
tasks/add-lldb-support
branch
from
93a3c4c
to
3484ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code in master (commit db8aaec) when trying to connect via LLDB with
gdb-remote 55555LLDB can't properly figure out the architecture that it's connecting too. This change adds support for LLDB'sqHostInforemote query string. After this change the gdb stub will respond back with a cpu type of ARM, a cpu subtype v4t, the endianness and the size of pointers.To test do the following on a machine with lldb installed:
Additionally, after adding support for the
qHostInfothere were some stack overflow crashes occurring that preventing things from fully working. Those fixes have been included in this PR as well.