Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce input delay by 1 frame and audio timing fix #331

Merged
merged 1 commit into from Dec 12, 2018
Merged

Reduce input delay by 1 frame and audio timing fix #331

merged 1 commit into from Dec 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 10, 2018

  • This PR adjusts timing for input, video and sound. This reduces input delay by reading and pre-process input before the main loop (CPULoop) this way makes the data already available during the loop instead of waiting for vblank to read the input.

  • Sound timings and video timings are also adjust, including the number of clock ticks required so that CPULoop will have enough ticks reach finish till vblank which takes about 280896 cycles. This makes it possible that video and sound can both be processed during vblank period which then ends the loop.

#332

Copy link
Contributor

@ZachBacon ZachBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve these changes, but since the CI is acting up on the mingw side of things, I'm not 100%. But you've done good work so I'm more than comfortable to accept this.

@ZachBacon ZachBacon merged commit 0d1b23c into visualboyadvance-m:master Dec 12, 2018
@ghost ghost deleted the gba_timings branch January 2, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant