Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rkitover This is a little bit of cleanup. On #94 we discussed about managing a single config file for all platforms (
vbam.ini
), so we needed to also include a migration path forvbam.cfg
on MacOS and Windows.We also had some stuff duplicated the
FILE_SEP
, like${XDG_CONFIG_HOME}//visualboyadvance-m
from the xdg functions. Although it has no problem, since all platforms understand the duplicateFILE_SEP
, it was a quick fix, so why not?Finally, it is always a good practice to set a pointer to NULL after deallocating it. This was missing from the variable
home
that was the cause of that segfault command line issue.