Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to tabs #1584

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add labels to tabs #1584

merged 2 commits into from
Jun 10, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Jun 10, 2024

Goals

Add labels to tabs in editor mode and preview mode.
We use the title of the charts.

The behavior of the tabs is as follows:

  • Each tab is of the same size for consistency
  • The ellipsis of the title is done by a semi transparent element
  • The tabs have a minimum width
  • The tabs list content can scroll once the tabs are too numerous and cannot shrink
  • The tabs list also indicate cut-off content via semi transparent element

How to test

  1. Open a chart
  2. Add 4 to 5 charts
  3. Add titles to each of the charts

Result

tabs-title.mp4

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 3:29pm

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Just a few thoughts, that do not block merging :)

I am not sure if we need to have this alone horizontal divider? 😄

Screenshot 2024-06-10 at 16 42 56 Screenshot 2024-06-10 at 16 43 16

Also I personally find it better when the Plus button was "sticky" to the current tab, currently there's a bigger gap 🤔

Screenshot 2024-06-10 at 16 45 51

@ptbrowne
Copy link
Collaborator Author

Sure, both behavior were not wanted ;) I fixed them.

@bprusinowski
Copy link
Collaborator

Looks great now, thanks 💯

@ptbrowne ptbrowne merged commit 7cba90c into main Jun 10, 2024
6 of 7 checks passed
@ptbrowne ptbrowne deleted the feat/tab-labels branch June 10, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants