Skip to content

Commit

Permalink
chore: new version
Browse files Browse the repository at this point in the history
  • Loading branch information
@visualjerk
visualjerk committed Jan 25, 2021
1 parent 18914a8 commit 34e24df
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.

2 comments on commit 34e24df

@julianlam
Copy link
Contributor

@julianlam julianlam commented on 34e24df Jan 25, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @visualjerk Thanks for this -- it is a major version bump, but are there any breaking changes?

If usage of the lib is the same, please reflect this in the release notes 😄 Renovate automatically takes those notes and puts it in the commit for the version bump (e.g. NodeBB/nodebb-plugin-composer-quill#161)

@visualjerk
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @julianlam

There is a breaking change, but only if you use custom regex for URL detection in the config of quill-magic-url.

Thanks for pointing that out. I added it to the release notes:

BREAKING CHANGE:

globalRegularExpression and urlRegularExpression are only used for url detection. Mail detection is handled with globalMailRegularExpression and mailRegularExpression

This only affects your project, if you use custom regular expressions for url detection.

Please sign in to comment.