Integrate code improvements and add linters #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds linters for YAML, Ansible, and Python files. The `.yamllint` file is updated to ignore the `.venv` directory and to enforce a minimum of one space between comments and content. The `.ansible-lint` file is updated to exclude the `.venv` directory. The `Makefile` is updated to include the new `linters.mak` file, which contains the targets for the linters. The linters are executed in the `lint` target.
This commit removes commented out code and fixes indentation in the molecule.yml file. The commented out code is not needed and the indentation is inconsistent, which can make the file harder to read.
… packages The bash-completion package is added to enable tab completion in the terminal. The following packages are removed as they are either redundant or not required: sudo, nano, iproute2, curl, htop, gnupg, and lsb-release.
The lint target is added to the Makefile to run all linters at once. This improves the development workflow by allowing developers to run all linters with a single command.
A new flake8 configuration file has been added to the .config directory. This file specifies the directories and files to exclude from flake8 linting.
…tory The flake8 configuration file was moved from the root directory to the .config directory to improve organization and avoid cluttering the root directory.
🔧 chore(postgrespro): move vars file to vars directory The comments and echo statements were removed from the linters.mak file to reduce noise in the output. The vars file was moved to the vars directory to improve organization and consistency with other roles.
This commit updates the contributing guidelines to include instructions on how to lint the codebase using `make lint`. It also adds a step to the existing instructions to test with linters.
vitabaks
reviewed
Apr 27, 2023
vitabaks
reviewed
Apr 27, 2023
…nclude_vars module The ansible.builtin prefix is redundant and can be removed from the include_vars module.
The molecule-lint target has been removed as it is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #306