Refactor Project Structure and Makefile Targets #357
Conversation
✨ feat(config): add make targets for testing and bootstrapping development environment 🔧 chore(config): move dev requirements to a separate file 🔧 chore(config): update make targets to include development environment The commit adds configuration files for yamllint and ansible-lint. It also adds make targets for testing and bootstrapping the development environment. The development environment is now bootstrapped separately from the production environment. The make targets have been updated to include the development environment. The dev requirements have been moved to a separate file.
✨ feat(workflows): add linters workflow to run all linters and improve code quality The Ansible-lint and Yamllint workflows have been removed as they are no longer needed. A new linters workflow has been added to run all linters and improve code quality. This new workflow runs on every push and pull request to the master branch. It sets the TERM environment variable, checks out the code, sets up Python 3.10, installs dependencies, and runs all linters using the `make lint` command.
|
Hi @ThomasSanson Thank you for your PR! I'm not sure that I would like to move and merge "ansible-llint.yml" and "yamllint.yml" workflows because I like it when I see the status of these two important linters in the README
|
|
Hi @vitabaks, Thank you for your feedback! I understand the value of having the status of the "ansible-llint.yml" and "yamllint.yml" workflows displayed separately in the README. I apologize for overlooking this. I will make the necessary corrections today to maintain the visibility of these two important linters. Thanks again for pointing this out. |
…improve code quality The Ansible-lint, Flake8, and Yamllint workflows have been added to the project to improve code quality. These workflows will run on every push and pull request to the master branch. The Ansible-lint workflow checks for syntax errors and best practices in Ansible code, the Flake8 workflow checks for PEP8 compliance and other code quality issues in Python code, and the Yamllint workflow checks for syntax errors and best practices in YAML files. The README.md file has also been updated to reflect the changes in the project.
|
Hello @vitabaks, I have taken into account your remarks and made the necessary modifications. I have restored the "ansible-lint.yml" and "yamllint.yml" workflows, and added Flake8 to improve the quality of the Python code. You can now see the status of these three important linters in the README. I invite you to review the modifications and let me know if there is anything else I should adjust. Thank you for your time and valuable feedback. |
|
hello @ThomasSanson Thank you! |
…ter readability The index and cluster types sections were reformatted to improve readability and make it easier to navigate the document. The changes include removing unnecessary characters, reordering the sections, and changing the formatting of the sub-sections. 🎨 style(README.md): reformat table for better readability The table was reformatted to improve readability and make it easier to compare the test results across different distributions.
…lity The table of test results has been reformatted to improve readability. The table now has a cleaner look and is easier to read.
Close #343