pgbouncer: Update pool size calculation algorithm #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement total pool size calculation enhancement for pgbouncer. Now it properly accounts for databases not defined in 'pgbouncer_pools' and optionally uses the 'pgbouncer_default_pool_size'. This provides a more accurate total pool size estimation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pool size calculation algorithm and add comprehensive code comments.
This PR addresses an issue with the calculation of the total size of pools in the pgbouncer configuration. The previous implementation had a flaw that resulted in incorrect pool size calculations. In this PR, the algorithm for calculating the pool size has been fixed to calculate the sum of the pool sizes accurately.
Additionally, this PR introduces detailed comments throughout the codebase. The comments provide clear explanations of the logic and purpose of each task, making the code more maintainable and easier to understand for future contributors.
The changes in this PR enhance the reliability and readability of the pgbouncer configuration code, ensuring accurate pool size calculations and facilitating smoother maintenance in the future.