Enable no-free-form rule and refactor tasks #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The no-free-form rule was removed from the skip_list in order to enable it. This rule checks that all tasks have a `task` key and that it is not a free-form task.
…set_fact tasks in consul role The service task in ansible-role-firewall was reformatted to use a dictionary for the service name and state. This improves readability and consistency with other tasks in the playbook. The set_fact tasks in the consul role were also reformatted to use a dictionary for the variable assignment. This improves readability and consistency with other tasks in the playbook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two primary changes to the project:
The
no-free-formrule was removed from theskip_listto enable it. This rule ensures that all tasks have ataskkey and are not free-form tasks. This change increases the robustness of the task structure in the project.The service task in
ansible-role-firewalland theset_facttasks in the consul role were reformatted. Instead of using a free-form task structure, these tasks now use a dictionary for the service name, state, and variable assignment. This restructuring improves the readability and consistency of these tasks with other tasks in the playbook