Removal of fqcn[action] rule from ansible-lint skip_list #378
Conversation
The fqcn[action] rule was removed from the skip_list as it is no longer necessary.
… community.docker collections The Ansible modules used in the playbook have been updated to use the community.general and community.docker collections. This is because the modules have been moved to these collections and are no longer available in the core Ansible distribution. This change ensures that the playbook remains compatible with the latest version of Ansible. 🐛 fix(roles): replace deprecated Ansible modules with their updated counterparts ✨ feat(roles): improve maintainability by using updated Ansible modules The deprecated Ansible modules have been replaced with their updated counterparts to ensure that the roles continue to work as expected. This improves the maintainability of the roles as the updated modules are more reliable and have better support. 🚚 chore(roles): update Ansible module names to use fully qualified names The Ansible modules used in the roles have been updated to use fully qualified names. This is to ensure that the correct modules are used and to avoid any potential conflicts with other modules. The updated modules are as follows: - community.postgresql.postgresql_schema - community.postgresql.postgresql_user - ansible.posix.authorized_key - ansible.posix.mount - ansible.posix.sysctl - community.general.timezone - community.general.make
|
I think within the framework of this PR, it is now necessary to set the fqdn for all modules throughout the code, which of course is a lot of time. @ThomasSanson Do you need my help with this? |
|
Thank you for your offer, but I'll handle this and gradually address the skip_list of ansible-lint. Regardless, this pull request will be approved. However, I must first change the minimum version of Ansible. |
🔨 chore(config_pgcluster.yml): update minimal Ansible version to 2.11.0 🔨 chore(deploy_pgcluster.yml): update minimal Ansible version to 2.11.0 🔨 chore(meta/main.yml): update minimum supported Ansible version to 2.11.0 The minimum supported Ansible version has been updated to 2.11.0 in all relevant files. This is done to ensure compatibility with the latest version of Ansible and to take advantage of its new features and improvements.
…rement This commit adds a new file named runtime.yml which specifies the minimum version of Ansible required to run the application. This file is important as it helps ensure that the application is run on a compatible version of Ansible.
This commit adds a newline at the end of the runtime.yml file to improve readability and ensure consistency with other files in the repository.
|
pull request is ready 😇 |
|
I skimmed through the code and found that there are still a lot of modules without fqdn. Please tell me why you translated only part of the code to fqdn and not the whole code? I understand that if we decided to use this style, then it should be followed throughout the code. For example and etc Or do I understand something wrong? |
|
I activated only I will handle the other part in a separate pull request. This way, it reduces the workload for your reviews too. |
|
thank you for the clarification. I completely agree with you, it is much more convenient to go gradually in small steps. |
This pull request introduces several updates and improvements to the project:
The
fqcn[action]rule has been removed from theskip_listas it is no longer necessary.The Ansible modules used in the playbook have been updated to use the
community.generalandcommunity.dockercollections. These modules have been moved to these collections and are no longer available in the core Ansible distribution. This change ensures that the playbook remains compatible with the latest version of Ansible.Deprecated Ansible modules have been replaced with their updated counterparts. This change improves the maintainability of the roles, as the updated modules are more reliable and have better support.
The Ansible module names used in the roles have been updated to use fully qualified names. This helps to avoid any potential conflicts with other modules