Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile Optimization with Multi-Stage Builds #387

Merged
merged 12 commits into from
Jul 11, 2023
Merged

Dockerfile Optimization with Multi-Stage Builds #387

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5d42bf0
first modification for issues 359
AurelienToitot Jun 29, 2023
ef52123
Correction of Docker test order
AurelienToitot Jun 30, 2023
3278411
Fix security error USER: root with hadolint DL3002
AurelienToitot Jul 3, 2023
592417f
ignore the packages
AurelienToitot Jul 7, 2023
59c3b6e
Merge branch 'vitabaks:master' into Issues_359_first_modification
AurelienToitot Jul 8, 2023
6c1705a
error ignore DL(3008,3009)
AurelienToitot Jul 8, 2023
7db31da
Using SHELL before RUN Line45
AurelienToitot Jul 8, 2023
beaf0c0
error ignore DL3008
AurelienToitot Jul 8, 2023
d56a4fb
error modification DL4006 line56
AurelienToitot Jul 8, 2023
94607ef
correction error SC2086 line58
AurelienToitot Jul 9, 2023
c88a85f
add jump line to the end
AurelienToitot Jul 9, 2023
dbb8852
modification FROM scratch
AurelienToitot Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 29 additions & 17 deletions .config/gitpod/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
FROM ubuntu:jammy
# First stage: Install build-time dependencies
FROM ubuntu:jammy as builder
vitabaks marked this conversation as resolved.
Show resolved Hide resolved
vitabaks marked this conversation as resolved.
Show resolved Hide resolved

USER root

vitabaks marked this conversation as resolved.
Show resolved Hide resolved
SHELL ["/bin/bash", "-o", "pipefail", "-c"]

# Copy Python version config file
COPY .config/python_version.config /tmp/

Expand All @@ -12,11 +11,10 @@ ARG NPM_VERSION=9.6.7
# Set a variable for the ungit version
ARG UNGIT_VERSION=1.5.23

# Update system and install packages, including Docker
# Replace "python3.10" with "$(cut -d '=' -f 2 /tmp/python_version.config)" in the apt-get install command
# Update system and install packages*
# hadolint ignore=DL3008,DL3013
RUN PYTHON_VERSION=$(cut -d '=' -f 2 /tmp/python_version.config) && \
vitabaks marked this conversation as resolved.
Show resolved Hide resolved
apt-get update \
RUN PYTHON_VERSION=$(cut -d '=' -f 2 /tmp/python_version.config) \
&& apt-get update \
&& apt-get upgrade -y \
&& apt-get install -y --no-install-recommends \
bash-completion \
Expand All @@ -38,23 +36,37 @@ RUN PYTHON_VERSION=$(cut -d '=' -f 2 /tmp/python_version.config) && \
vim \
wget \
&& python3 -m pip install --no-cache-dir --upgrade pip \
&& python3 -m pip install --no-cache-dir virtualenv \
# Install Docker
&& curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg \
&& python3 -m pip install --no-cache-dir virtualenv

# Install Docker
FROM builder as docker-installer

RUN curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg \
&& echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu \
vitabaks marked this conversation as resolved.
Show resolved Hide resolved
vitabaks marked this conversation as resolved.
Show resolved Hide resolved
$(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null \
&& apt-get update \
&& apt-get install -y --no-install-recommends docker-ce docker-ce-cli containerd.io \
# Install npm and ungit using the versions specified in the variables
&& curl -fsSL https://deb.nodesource.com/setup_20.x |bash - \
&& apt-get install -y --no-install-recommends docker-ce docker-ce-cli containerd.io

# Install npm and ungit
FROM docker-installer as npm-installer

RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \
&& apt-get install -y --no-install-recommends nodejs \
vitabaks marked this conversation as resolved.
Show resolved Hide resolved
vitabaks marked this conversation as resolved.
Show resolved Hide resolved
&& npm install -g npm@${NPM_VERSION} \
&& npm install -g \
vitabaks marked this conversation as resolved.
Show resolved Hide resolved
ungit@${UNGIT_VERSION} \
# Clean
&& apt-get clean && rm -rf /var/lib/apt/lists/* tmp/*
ungit@${UNGIT_VERSION}

# Cleanup
FROM npm-installer as cleanup

RUN apt-get clean && rm -rf /var/lib/apt/lists/* tmp/*

# Final stage: Setup final image and user
FROM ubuntu:jammy

vitabaks marked this conversation as resolved.
Show resolved Hide resolved
COPY --from=cleanup / /

# Create the gitpod user. UID must be 33333.
RUN useradd -l -u 33333 -G sudo -md /home/gitpod -s /bin/bash -p gitpod gitpod

USER gitpod
USER gitpod
Loading