Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Fully Qualified Collection Name (FQCN) to each Ansible task #412

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Add the Fully Qualified Collection Name (FQCN) to each Ansible task #412

merged 2 commits into from
Jul 12, 2023

Conversation

pa-decarvalho
Copy link
Contributor

This pull request aims to adhere to Ansible best practices and add FQCN at each task level.

In order to achieve this, the fqcn[action-core] rule has been removed from .config/ansible-lint.yml file.

@vitabaks
Copy link
Owner

@pa-decarvalho Hi!

Great! It's high time to do it.

Thank you very much for your contribution!

@vitabaks
Copy link
Owner

cc @ThomasSanson

@vitabaks vitabaks changed the title Remove fqcn from ansible lint Add the fully qualified collection name (FQCN) to each Ansible task Jul 12, 2023
@vitabaks vitabaks changed the title Add the fully qualified collection name (FQCN) to each Ansible task Add the Fully Qualified Collection Name (FQCN) to each Ansible task Jul 12, 2023
Copy link
Sponsor Contributor

@ThomasSanson ThomasSanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitabaks

I've gone through the 111 files (what a job 👏👌)

Everything's fine from my end

Well done, Philippe, and thank you ! 🎉🙏

On to the next one ! 💪😊

@vitabaks vitabaks merged commit d996f08 into vitabaks:master Jul 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants