Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the pg_ctlcluster command with pg_ctl and increase the timeout #590

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Replace the pg_ctlcluster command with pg_ctl and increase the timeout #590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5ae615
Replace the pg_ctlcluster command with pg_ctl and increase the timeout
vitabaks Feb 29, 2024
9d19113
formatting
vitabaks Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
59 changes: 11 additions & 48 deletions roles/patroni/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,23 +500,11 @@
- pg_ctl_status_result.rc != 0
- pg_ctl_status_result.rc != 3

# "Debian"
- name: Prepare PostgreSQL | start PostgreSQL on Master
become: true
become_user: postgres
ansible.builtin.command: "/usr/bin/pg_ctlcluster {{ postgresql_version }} {{ postgresql_cluster_name }} start"
register: pg_start_on_master
when: pg_ctl_status_result.rc == 3 and
(ansible_os_family == "Debian" and postgresql_packages|join(" ") is not search("postgrespro"))

# "RedHat" or PostgresPro
- name: Prepare PostgreSQL | start PostgreSQL on Master
become: true
become_user: postgres
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl start -D {{ postgresql_data_dir }}"
register: pg_start_on_master
when: pg_ctl_status_result.rc == 3 and
(ansible_os_family == "RedHat" or postgresql_packages|join(" ") is search("postgrespro"))
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl start -D {{ postgresql_data_dir }} -w -t 1800"
when: pg_ctl_status_result.rc == 3

- name: Prepare PostgreSQL | check PostgreSQL is accepting connections
become: true
Expand Down Expand Up @@ -589,21 +577,11 @@
delay: 10
when: pg_ctl_status_result.rc == 0

# "Debian"
- name: Prepare PostgreSQL | stop PostgreSQL (will be managed by patroni)
become: true
become_user: postgres
ansible.builtin.command: "/usr/bin/pg_ctlcluster {{ postgresql_version }} {{ postgresql_cluster_name }} stop -m fast -- -w -t 600"
when: (checkpoint_result.rc is defined and checkpoint_result.rc == 0) and
(ansible_os_family == "Debian" and postgresql_packages|join(" ") is not search("postgrespro"))

# "RedHat" or PostgresPro
- name: Prepare PostgreSQL | stop PostgreSQL (will be managed by patroni)
become: true
become_user: postgres
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl stop -D {{ postgresql_data_dir }} -m fast -w -t 600"
when: (checkpoint_result.rc is defined and checkpoint_result.rc == 0) and
(ansible_os_family == "RedHat" or postgresql_packages|join(" ") is search("postgrespro"))
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl stop -D {{ postgresql_data_dir }} -m fast -w -t 1800"
when: checkpoint_result.rc is defined and checkpoint_result.rc == 0

- name: Prepare PostgreSQL | check PostgreSQL is stopped
become: true
Expand Down Expand Up @@ -706,17 +684,9 @@
failed_when: false
when: not keep_patroni_dynamic_json|bool

- name: Start PostgreSQL for Recovery # Debian
ansible.builtin.command: "/usr/bin/pg_ctlcluster {{ postgresql_version }} {{ postgresql_cluster_name }} start -o '-c hot_standby=off'"
when: ansible_os_family == "Debian" and
(is_master | bool or
(not is_master | bool and 'pgbackrest' in patroni_create_replica_methods))

- name: Start PostgreSQL for Recovery # RedHat or PostgresPro
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl start -D {{ postgresql_data_dir }} -o '-c hot_standby=off'"
when: (ansible_os_family == "RedHat" or postgresql_packages|join(" ") is search("postgrespro")) and
(is_master | bool or
(not is_master | bool and 'pgbackrest' in patroni_create_replica_methods))
- name: Start PostgreSQL for Recovery
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl start -D {{ postgresql_data_dir }} -o '-c hot_standby=off' -w -t 1800"
when: is_master | bool or (not is_master | bool and 'pgbackrest' in patroni_create_replica_methods)

- name: Waiting for PostgreSQL Recovery to complete (WAL apply)
ansible.builtin.command: >-
Expand All @@ -728,24 +698,17 @@
delay: 30
changed_when: false
failed_when: false
when: is_master | bool or
(not is_master | bool and 'pgbackrest' in patroni_create_replica_methods)
when: is_master | bool or (not is_master | bool and 'pgbackrest' in patroni_create_replica_methods)

- name: Check that PostgreSQL is stopped
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl status -D {{ postgresql_data_dir }}"
register: pg_ctl_status_result
changed_when: false
failed_when: false

- name: Stop PostgreSQL # "Debian"
ansible.builtin.command: "/usr/bin/pg_ctlcluster {{ postgresql_version }} {{ postgresql_cluster_name }} stop -m fast -- -w -t 600"
when: ansible_os_family == "Debian" and
(pg_ctl_status_result.rc is defined and (pg_ctl_status_result.rc != 3 and pg_ctl_status_result.rc != 4))

- name: Stop PostgreSQL # "RedHat" or PostgresPro
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl stop -D {{ postgresql_data_dir }} -m fast -w -t 600"
when: (ansible_os_family == "RedHat" or postgresql_packages|join(" ") is search("postgrespro")) and
(pg_ctl_status_result.rc is defined and (pg_ctl_status_result.rc != 3 and pg_ctl_status_result.rc != 4))
- name: Stop PostgreSQL
ansible.builtin.command: "{{ postgresql_bin_dir }}/pg_ctl stop -D {{ postgresql_data_dir }} -m fast -w -t 1800"
when: pg_ctl_status_result.rc is defined and (pg_ctl_status_result.rc != 3 and pg_ctl_status_result.rc != 4)
when: patroni_cluster_bootstrap_method == "pgbackrest"
become: true
become_user: postgres
Expand Down