You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Punjabi is using the wrong language code, Simplified Chinese doesn't use both the 'zh' and 'zh-cn' language codes, and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well)
#4
Closed
rawr51919 opened this issue
Mar 4, 2019
· 1 comment
The language code for Punjabi is labelled as ma when it should be pa. ma will just give the source string when trying to translate into Punjabi, while pa will give the proper Punjabi translation. Hebrew translations are supported under both the he and iw language codes, but only iw is supported in this module (same goes for Simplified Chinese where both zh and zh-cn language codes are supported for translations, but only zh-cn is supported in this module). China also has the main Translate URL (translate.google.com) banned, so allowing for anyone to use any language Translate URL they wish will fix this issue. A PR has been created to allow these issues to be fixed (PRs #6, #7, and vitalets/google-translate-token#2). These are all long-standing issues that have persisted since the days of the original repo (see matheuss#48, matheuss#59, matheuss#60, matheuss#62, matheuss#68, and matheuss/google-translate-token#10 for more details on this). (matheuss#48, matheuss#59, matheuss#62, and matheuss#68 have been fixed already).
The text was updated successfully, but these errors were encountered:
rawr51919
changed the title
Punjabi is using the wrong language code in languages.js
Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well)
Mar 4, 2019
rawr51919
changed the title
Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well)
Punjabi is using the wrong language code in languages.js
Mar 4, 2019
rawr51919
changed the title
Punjabi is using the wrong language code in languages.js
Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well)
Mar 4, 2019
rawr51919
changed the title
Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well)
Punjabi is using the wrong language code and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well)
Mar 4, 2019
rawr51919
changed the title
Punjabi is using the wrong language code and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well)
Punjabi is using the wrong language code, Simplified Chinese doesn't use both the 'zh' and 'zh-cn' language codes, and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well)
Mar 5, 2019
The language code for Punjabi is labelled as
ma
when it should bepa
.ma
will just give the source string when trying to translate into Punjabi, whilepa
will give the proper Punjabi translation. Hebrew translations are supported under both thehe
andiw
language codes, but onlyiw
is supported in this module (same goes for Simplified Chinese where bothzh
andzh-cn
language codes are supported for translations, but onlyzh-cn
is supported in this module). China also has the main Translate URL (translate.google.com
) banned, so allowing for anyone to use any language Translate URL they wish will fix this issue. A PR has been created to allow these issues to be fixed (PRs #6, #7, and vitalets/google-translate-token#2). These are all long-standing issues that have persisted since the days of the original repo (see matheuss#48, matheuss#59, matheuss#60, matheuss#62, matheuss#68, and matheuss/google-translate-token#10 for more details on this). (matheuss#48, matheuss#59, matheuss#62, and matheuss#68 have been fixed already).The text was updated successfully, but these errors were encountered: