Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punjabi is using the wrong language code, Simplified Chinese doesn't use both the 'zh' and 'zh-cn' language codes, and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well) #4

Closed
rawr51919 opened this issue Mar 4, 2019 · 1 comment

Comments

@rawr51919
Copy link

rawr51919 commented Mar 4, 2019

The language code for Punjabi is labelled as ma when it should be pa. ma will just give the source string when trying to translate into Punjabi, while pa will give the proper Punjabi translation. Hebrew translations are supported under both the he and iw language codes, but only iw is supported in this module (same goes for Simplified Chinese where both zh and zh-cn language codes are supported for translations, but only zh-cn is supported in this module). China also has the main Translate URL (translate.google.com) banned, so allowing for anyone to use any language Translate URL they wish will fix this issue. A PR has been created to allow these issues to be fixed (PRs #6, #7, and vitalets/google-translate-token#2). These are all long-standing issues that have persisted since the days of the original repo (see matheuss#48, matheuss#59, matheuss#60, matheuss#62, matheuss#68, and matheuss/google-translate-token#10 for more details on this). (matheuss#48, matheuss#59, matheuss#62, and matheuss#68 have been fixed already).

@rawr51919 rawr51919 changed the title Punjabi is using the wrong language code in languages.js Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well) Mar 4, 2019
@rawr51919 rawr51919 changed the title Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well) Punjabi is using the wrong language code in languages.js Mar 4, 2019
@rawr51919 rawr51919 changed the title Punjabi is using the wrong language code in languages.js Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well) Mar 4, 2019
@rawr51919 rawr51919 changed the title Punjabi is using the wrong language code in languages.js (China also cannot use this library either, so this will fix that as well) Punjabi is using the wrong language code and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well) Mar 4, 2019
@rawr51919 rawr51919 changed the title Punjabi is using the wrong language code and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well) Punjabi is using the wrong language code, Simplified Chinese doesn't use both the 'zh' and 'zh-cn' language codes, and Hebrew doesn't use both the 'he' and 'iw' language codes in languages.js (China also cannot use this library either, so this will fix that as well) Mar 5, 2019
@vitalets
Copy link
Owner

As PRs are merged this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants