Update index.js to fix translation requests originating from China #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the index.js to resolve an issue where the Chinese can't use this library nor it's parent to translate using code from an old PR to this library's parent repo.
This was referenced Mar 4, 2019
rawr51919
changed the title
|
Thanks! Have a look on comment here vitalets/google-translate-api#5 (comment) |
|
Seeing that your approach you specified there is the better approach, allowing for more URLs to be used than just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the index.js to resolve an issue where the Chinese can't use this library nor it's parent to translate using code from an old PR to this library's parent repo. This is part of the PR from vitalets/google-translate-api#5 fixing issues vitalets/google-translate-api#4, matheuss/google-translate-api#59, matheuss/google-translate-api#60, matheuss/google-translate-api#62, matheuss/google-translate-api#68, and matheuss#10 over there, using code from an old PR sent to the unmaintained upstream (matheuss#11, to be exact).