improvement: set scenario timeout via test.setTimeout instead of anon…

…ymous describe (#139)

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## dev
+* improvement: set scenario timeout via `test.setTimeout` instead of anonymous describe ([#139](https://github.com/vitalets/playwright-bdd/issues/139))
 * feature: add `@slow` special tag ([#138](https://github.com/vitalets/playwright-bdd/issues/138))
 * improvement: relax rules for guessing fixtures in decorator steps, introduce new config option `statefulPoms` for more strict checks ([#102](https://github.com/vitalets/playwright-bdd/issues/102))
 

src/gen/formatter.ts

@@ -69,17 +69,18 @@ export class Formatter {
     if (!children.length) return [`${firstLine}});`, ''];
     const lines = [
       firstLine, // prettier-ignore
+      ...this.testTimeout(node).map(indent),
       ...this.markAsSlow(node).map(indent),
       ...this.markAsFailed(node).map(indent),
       ...children.map(indent),
       `});`,
       '',
     ];
-    // wrap test into anonymous describe in case of retries / timeout tags
-    const specialTagsConfigure = this.describeConfigure(node);
-    return specialTagsConfigure.length
+    // Wrap test into anonymous describe in case of retries
+    // See: https://github.com/microsoft/playwright/issues/10825
+    return node.specialTags.retries
       ? this.wrapInAnonymousDescribe([
-          ...specialTagsConfigure.map(indent),
+          ...this.describeConfigure(node).map(indent),
           '',
           ...lines.map(indent),
         ])

test/special-tags/features/timeout.feature

@@ -9,7 +9,11 @@ Feature: timeout tag
   Scenario Outline: scenario 2
     Given success step <start>
 
+    @timeout:2000
     Examples:
       | start |
       | 2     |
+
+    Examples:
+      | start |
       | 3     |

test/special-tags/test.mjs

@@ -64,9 +64,9 @@ function checkRetriesTag() {
 function checkTimeoutTag() {
   testDir.expectFileContains(`.features-gen/timeout.feature.spec.js`, [
     `${' '.repeat(2)}test.describe.configure({"timeout":5000});`,
-    `${' '.repeat(2)}test.describe(() => {`,
-    `${' '.repeat(4)}test.describe.configure({"timeout":4000});`,
+    `${' '.repeat(4)}test.setTimeout(4000);`,
     `${' '.repeat(4)}test.describe.configure({"timeout":3000});`,
+    `${' '.repeat(6)}test.setTimeout(2000);`,
   ]);
 }