Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox and reports #327

Closed
mpele opened this issue Nov 16, 2015 · 10 comments

Comments

Projects
None yet
3 participants
@mpele
Copy link
Contributor

commented Nov 16, 2015

It looks like that reports doesn't work with firefox.
I haven't noticed any errors - just, nothing happens when it is clicked on Generate.

@vitalidze

This comment has been minimized.

Copy link
Owner

commented Nov 16, 2015

Thanks for reporting. I confirm that it does not work for me in firefox as well.

@vitalidze vitalidze added the bug label Nov 16, 2015

@gpproton

This comment has been minimized.

Copy link

commented Nov 16, 2015

This same issue affects Microsoft edge browser.

Omonluimhen Godwin Peter

IT/Tracking
Officer | Beta Bridges Ltd

+2348083353682

godwin@betabridges.com

godwin@peter.com.ng

Date: Mon, 16 Nov 2015 09:43:56 -0800
From: notifications@github.com
To: traccar-web@noreply.github.com
Subject: Re: [traccar-web] Firefox and reports (#327)

Thanks for reporting. I confirm that it does not work for me in firefox as well.


Reply to this email directly or view it on GitHub.

vitalidze added a commit that referenced this issue Nov 16, 2015

@vitalidze

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2015

I have fixed the issue. Now it works fine in both firefox and chrome. The fixed version is deployed on demo site https://d.traccar.litvak.su/ @gpproton can you please try running reports from Microsoft Edge web browser?

@mpele

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2015

It works now :)
Great work!
May I ask - why it is forced to report be saved before it is opened? Why doesn't it silently open in new tab?

@vitalidze

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2015

My goal was to implement a self-contained reports, which can be then distributed anyhow. Probably in next versions it will be possible to save reports in formats other than HTML.

@vitalidze

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2015

Fixed, written news, updated latest and demo versions.

@vitalidze vitalidze closed this Nov 17, 2015

@mpele

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2015

I would like to suggest that the "initial" report should be in new tab and
on that page should be link/button for saving report in available formats.

On Tue, Nov 17, 2015 at 8:15 AM, Vitaly Litvak notifications@github.com
wrote:

My goal was to implement a self-contained reports, which can be then
distributed anyhow. Probably in next versions it will be possible to save
reports in formats other than HTML.


Reply to this email directly or view it on GitHub
#327 (comment)
.

@vitalidze

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2015

I don't see much value in this. As I have seen in existing reports they work in similar way. Some of them try to display report in same window, but it will be too much for the web UI especially if report is big enough.

Current implementation also may allow to set up a schedule and then send reports by emails. I believe this is a better use-case for reports.

@vitalidze

This comment has been minimized.

Copy link
Owner

commented Nov 17, 2015

I will think about adding some kind of option to 'Preview' report in a separate tab. It should be quite easy to implement, but the use-case is still not very clean for me.

vitalidze added a commit that referenced this issue Nov 19, 2015

For #327 - added possibility to preview reports without saving, added…
… possibility to disable filtering of data on reports (probably helps for #329)

vitalidze added a commit that referenced this issue Nov 24, 2015

@vitalidze

This comment has been minimized.

Copy link
Owner

commented Nov 24, 2015

Implemented, written news, updated latest and demo versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.