Added OrdnanceSurvey Bing Layer for UK users. #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalidze
reviewed
Oct 10, 2016
| ROAD("Road"), | ||
| HYBRID("AerialWithLabels"), | ||
| AERIAL("Aerial"), | ||
| ordnancesurvey("ordnancesurvey"); |
There was a problem hiding this comment.
Please change enum element name to be in upper-case letters.
| @@ -86,6 +86,7 @@ public double toKnots(double speed) { | |||
| BING_ROAD("Bing Road") { @Override public boolean isBing() { return true; } }, | |||
| BING_HYBRID("Bing Hybrid") { @Override public boolean isBing() { return true; } }, | |||
| BING_AERIAL("Bing Aerial") { @Override public boolean isBing() { return true; } }, | |||
| BING_OS("Bing OSGB") { @Override public boolean isBing() { return true; } }, | |||
There was a problem hiding this comment.
Let's name enum element in a more descriptive way, like BING_ORDNANCE_SURVEY, or at least BING_OSGB.
removing erroneously added file
deleted erroneously created file
|
Makes sense, I've made those changes to the branch, but haven't yet had the chance to compile and test |
|
Thank you for considering these changes. Now please check that it is working on your side and if it does I will merge changes. |
|
I've just compiled and confirmed that it is working fine, on both "desktop" and mobile versions. |
|
Squashed and merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional layer for UK users with valid Bing Key, to access the UK Ordnance Survey mapping layer of Bing Maps.
Have added amended version of GWT openlayers bing layers source, with added layer type of ordnancesurvey" to allow traccar files to use the UK only layer.
Amended the MapView.java to add "Bing OSGB" as an option to use the ordnancesurvey layer.
Amended the mobile traccar-mobile.js to use the "Bing OSGB" option and ordnancesurvey layer.