Revert "Exclude symlinks from sync" #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankatins
force-pushed
the
revert_symlink_handling_in_sync
branch
from
39fe961
to
86f43d8
Compare
This reverts commit b47dd70. This could trigger a infinite loop between the timer unit (running a sync and changing the griveignore file at the start) and the changes unit (reacting to the griveignore change and retriggering the sync).
jankatins
force-pushed
the
revert_symlink_handling_in_sync
branch
from
86f43d8
to
c7a949d
Compare
|
@vitalif this would also be good to include as it is a clear bug :-( |
|
@vitalif Sorry, another ping. Also tested via https://github.com/jankatins/grive2 on two computers |
|
Okay)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b47dd70.
As discovered in #241 the griveignore handling in the sync script could trigger a infinite loop between the timer unit (running a sync and changing the griveignore file at the start) and the changes unit (reacting to the griveignore change and retriggering the sync).
Reverting for now, as requested by the original author @psfloyd in #241 (comment)
Closes: #241