Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ZAsync.as by-name #140

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Make ZAsync.as by-name #140

merged 1 commit into from
Nov 24, 2023

Conversation

vitaliihonta
Copy link
Owner

Changes being made

ZAsync.as now accepts a by-name parameter. It's useful in case a side effect is made in the as body

Additional context

Please provide any context of the changes if needed

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6605875) 37.28% compared to head (449b8c9) 37.28%.

Files Patch % Lines
.../src/main/scala/zio/temporal/workflow/ZAsync.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   37.28%   37.28%           
=======================================
  Files         126      126           
  Lines        4820     4820           
=======================================
  Hits         1797     1797           
  Misses       3023     3023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitaliihonta vitaliihonta merged commit 7522f0e into main Nov 24, 2023
7 checks passed
@vitaliihonta vitaliihonta deleted the feature/zasync-minor-fix branch November 24, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants