Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swagger-ui 敢不敢不要把资源写死 #14

Closed
lqx131499 opened this issue Aug 24, 2020 · 5 comments
Closed

swagger-ui 敢不敢不要把资源写死 #14

lqx131499 opened this issue Aug 24, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@lqx131499
Copy link

C:\thirds\Python37\Lib\site-packages\ninja\templates\ninja\swagger.html

<script src="https://cdn.jsdelivr.net/npm/swagger-ui-dist@3/swagger-ui-bundle.js"></script>
@vitalik
Copy link
Owner

vitalik commented Aug 24, 2020

@lqx131499 I'm not sure I understand the issue...

@lqx131499
Copy link
Author

I mean to make the referenced resources configurable, because the network in many places is not connected to the Internet.

Location: Lib\site-packages\ninja\templates\ninja\swagger.html

Where needs to be configured:

<script src="https://cdn.jsdelivr.net/npm/swagger-ui-dist@3/swagger-ui-bundle.js"></script>

@vitalik vitalik added the enhancement New feature or request label Aug 24, 2020
@MaxZzyo
Copy link

MaxZzyo commented Dec 23, 2020

23333333

vitalik added a commit that referenced this issue Jan 5, 2021
@vitalik
include swagger-ui into dist (#14)
5bdcc43
@vitalik
Copy link
Owner

vitalik commented Jan 13, 2021 •
edited

@lqx131499 @MaxZzyo

this should work now

Please install latest version, and put "ninja" to INSTALLED_APPS

(Note: if ninja is in INSALLED_APPS - then local js files will be used instead of CDN)

@vitalik vitalik closed this as completed Mar 21, 2021
@lqx131499
Copy link
Author

ok thanks💪🏻💪🏻💪🏻💪🏻💪🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vitalik @lqx131499 @MaxZzyo