Fix #666: Support auth inheritance for routers #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for approving the CI run. Fixed the lint errors, it shouldn't be failing now. |
|
@vitalik Could you please rerun the CI checks and take a pass on this if it's not an issue? 😃 |
|
@vitalik, I checked why black in codestyle was breaking for untouched files, turns out black released a new version 23.1.0 10 hours back and that was used for my last CI run. So I have updated the PR by formatting those files with the new version and updated the version of black in pre-commit-config yaml file as well. Confirmed the checks in my forked repo in a PR over here, the checks are passing. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #666 and adds support for the inheritance of auth in routers.