Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional field of UploadedFile optional #766

Merged
merged 1 commit into from
May 22, 2023

Conversation

karlosss
Copy link
Contributor

UploadedFile.__modify_schema__ has a field parameter that is not used in the method body, is typed as Optional, but still requires a value. Schema generation fails because of the value for this parameter not being provided.

@vitalik vitalik merged commit 57bbad8 into vitalik:master May 22, 2023
37 checks passed
@karlosss
Copy link
Contributor Author

thanks for the fast review and merge!

@vitalik
Copy link
Owner

vitalik commented May 22, 2023

sure, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants