adding tests

vitaly-t · Aug 13, 2020 · eedc222 · eedc222
1 parent 3b7f392
commit eedc222
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/static.ts b/src/static.ts
@@ -84,7 +84,8 @@ export function parseHost(host: string, direct?: boolean): IParsedHost | null {
         }
         if (h.name || h.port) {
             Object.defineProperty(h, 'toString', {
-                value: (options: IEncodingOptions) => fullHostName(h, options)
+                value: (options: IEncodingOptions) => fullHostName(h, options),
+                enumerable: false
             });
             return h;
         }

diff --git a/test/main.spec.ts b/test/main.spec.ts
@@ -660,6 +660,11 @@ describe('parseHost', () => {
         expect(parseHost('a.sock')).to.eql({name: 'a.sock', type: 'socket'});
         expect(parseHost('/a')).to.eql({name: '/a', type: 'socket'});
         expect(parseHost('a/')).to.eql({name: 'a/', type: 'socket'});
+
+        // TODO: host parsing is a bit buggy, needs overhaul
+        //    odd/arguable tests:
+        // expect(parseHost('123.0.0.1-hello')).to.eql({name: '123.0.0.1-hello', type: 'IPv4'});
+        // expect(parseHost('[::]/here')).to.eql({name: '[::]here', type: 'IPv6'});
     });
     it('must use inside spaces', () => {
         expect(parseHost(' a b ')).to.eql({name: 'a b', type: 'domain'});