Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow tilde in the URL #30

Closed
vitaly-t opened this issue May 3, 2020 · 1 comment
Closed

Disallow tilde in the URL #30

vitaly-t opened this issue May 3, 2020 · 1 comment
Labels
enhancement

Comments

@vitaly-t
Copy link
Owner

vitaly-t commented May 3, 2020 •
edited
Loading

According to the official sources, tilde / ~ should not be allowed inside URL, unless encoded as %7E.

Currently, the library allows tilde, though it is handled inconsistently.

It should be just removed / disallowed, i.e. to throw an error when encountered.
vitaly-t added a commit that referenced this issue May 3, 2020
@vitaly-t
implementing #30
8c20e59
@vitaly-t
Copy link
Owner Author

vitaly-t commented May 3, 2020 •
edited
Loading

Implemented in v3.2.2, to throw standard error on any tilde encounter:

Invalid URL character '~' at position ...

If you want a tilde in the URL, it has to be encoded as %7E or %7e.

@vitaly-t vitaly-t closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitaly-t