Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harfbuzz 1.4.6 #28

Merged
merged 1 commit into from Jun 19, 2017
Merged

Add harfbuzz 1.4.6 #28

merged 1 commit into from Jun 19, 2017

Conversation

ebraminio
Copy link
Contributor

@ebraminio ebraminio commented Jun 12, 2017

I wanted to do this anyway but interestingly I just motivated more as pathway27/bookr-mod-vita#2

harfbuzz is a fundamental text rendering library used on various platforms, including and interestingly, PS4 also.

Lets see how this goes.

@ebraminio
Copy link
Contributor Author

Well, this looks tricky :) Just reproduced the issue locally, will try to fix it soon.

@ebraminio ebraminio closed this Jun 12, 2017
@ebraminio
Copy link
Contributor Author

Asked on harfbuzz mailing list

@ebraminio
Copy link
Contributor Author

harfbuzz/harfbuzz#451 is related also it seems

@ebraminio
Copy link
Contributor Author

A possible fix is here harfbuzz/harfbuzz#496

@ebraminio
Copy link
Contributor Author

This is ready to merge also I guess.

@xyzz xyzz merged commit 784ad30 into vitasdk:master Jun 19, 2017
@Ghabry
Copy link
Contributor

Ghabry commented Jun 19, 2017

freetype and harfbuzz have a circular dependency on each other.
To get harfbuzz support in freetype you have to:

  1. Compile freetype without harfbuzz. Done 👍
  2. Compile harfbuzz. Done 👍
  3. Compile freetype with harfbuzz. Not yet 👎

@xyzz
Copy link
Contributor

xyzz commented Jun 19, 2017

I think it would be enough to add harfbuzz detection to freetype VITABUILD, then add freetype after harfbuzz to travis_packages.sh like this:

b freetype
b harfbuzz
b freetype

@ebraminio
Copy link
Contributor Author

Good news :) next version of harfbuzz won't need the patch I attached here as harfbuzz/harfbuzz#496

@ebraminio
Copy link
Contributor Author

@xyzz: I guess you are right, have a look at also https://gist.github.com/roxlu/0108d45308a0434e27d4320396399153#file-cmakelists-txt

@Ghabry
Copy link
Contributor

Ghabry commented Nov 27, 2017

Yeah that would work, for the easyrpg deps we do it this way: https://github.com/EasyRPG/buildscripts/blob/master/linux-static/2_build_toolchain.sh#L136
Just use --without-harfbuzz and --with-harfbuzz

(install_lib is just a func that calls configure & make install)

@ebraminio
Copy link
Contributor Author

So this seems doable but I am in doubt for the best and easiest solution so filed #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants