Change import format to yaml #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
d3m3vilurr
reviewed
Nov 28, 2016
| @@ -36,6 +37,7 @@ int yaml_iterate_sequence(yaml_node *node, sequence_functor functor, void *userd | |||
|
|
|||
| int process_32bit_integer(yaml_node *node, uint32_t *nid); | |||
| int process_boolean(yaml_node *node, uint32_t *boolean); | |||
| int process_bool(yaml_node *node, bool *boolean); | |||
There was a problem hiding this comment.
cannot use process_boolean? that look same (least same in c)
There was a problem hiding this comment.
I got a warning between uint32_t and bool
|
seems like we're leaking memory in every strdup |
xyzz
reviewed
Nov 29, 2016
| } | ||
|
|
||
| char* booltostr(char *buf, int x){ | ||
| if(x){ |
xyzz
reviewed
Nov 29, 2016
| { | ||
| json_t *json_symbols = json_object(); | ||
| char* hextostr(char *buf, int x){ | ||
| sprintf(buf,"0x%x",x); |
There was a problem hiding this comment.
let's remove buf argument completely here and below and make it
static char buf[20];
sprintf(buf, "0x%x", x);
return buf;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP