Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: allow for different source image for dark mode splash screens #29

Closed
ollema opened this issue Dec 25, 2023 · 2 comments · Fixed by #31
Closed

feature request: allow for different source image for dark mode splash screens #29

ollema opened this issue Dec 25, 2023 · 2 comments · Fixed by #31
Assignees
@userquin
Labels
enhancement New feature or request

Comments

@ollema
Copy link

ollema commented Dec 25, 2023

No description provided.

@userquin userquin self-assigned this Dec 26, 2023
@userquin userquin added the enhancement New feature or request label Dec 26, 2023
@userquin
Copy link
Member

userquin commented Dec 26, 2023 •
edited
Loading

@ollema something like this (the P is gray in dark and black in light)? The dark image can be in any place, by default will return the original image if missing darkImageResolver or returning undefined (we also need to handle multiple images: when using only 1 image you can return the readFile result)

imagen

@userquin userquin mentioned this issue Dec 26, 2023
Merged
@userquin
Copy link
Member

@ollema new feat in v0.2.2, also included in pwa docs (CLI): example in the playground conf file

@anderskiaer anderskiaer mentioned this issue Mar 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@userquin userquin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: custom source image for apple dark splash screens vite-pwa/assets-generator
2 participants
@userquin @ollema