Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add api support #24

Merged
merged 37 commits into from
Dec 10, 2023
Merged

feat!: add api support #24

merged 37 commits into from
Dec 10, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Dec 3, 2023

This PR includes:

  • expose presets (all) package exports
  • update pnpm to 8.12.0
  • new api subpackage:
    • ✔️ apple splash screen html generation ( ✔️ we need to expose the link as object)
    • ✔️ maskable icon generation ( ✔️ update build module to use the new function)
    • ✔️ transparent icon generation ( ✔️ update build module to use the new function)
    • ✔️ favicon generation ( ✔️ update build module to use the new function)
    • ✔️ apple splash screen generation : there is no need, using maskable function ( ✔️ update build module to use the new function)
    • ✔️ include also html head generation ( ✔️ include generation in CLI)
  • add dual ESM/CJS package exports (moved from ESM-only to ESM-first: this package does not use any export default)
  • add vitest (v1.0.4) tests using In-Source Testing
  • add new minimal-2023 preset: https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7
  • deprecate minimal preset: still default preset
  • update pwa docs, can be found in this PR docs: include assets generator v0.1.0 changes docs#112 :
    • ✔️ include new minimal-2023 preset
    • ✔️ deprecate minimal preset
    • ✔️ include initial api docs
    • ✔️ include migration from minimal to minimal-2023 preset
    • ✔️ include new section for favicons and apple touch icon link generation

We need to review updating to sharp v0.33.0, requires Node 18.17.0 and adding optional dependencies (will go in another PR once released a new minor with this PR): https://sharp.pixelplumbing.com/install (I need to review it, it seems the dependency is required in the target project)

imagen

/cc @PurpleTape if you want to contribute

releated to #20 (list entry 5)

closes #22

@userquin userquin marked this pull request as ready for review December 8, 2023 18:03
@userquin userquin changed the title feat: add api support feat!: add api support Dec 9, 2023
@userquin userquin merged commit 6bc8503 into main Dec 10, 2023
@userquin userquin deleted the userquin/feat-add-api-support branch December 10, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update default preset
1 participant