Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(injectManifest): astro with env files not working #43

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Mar 21, 2024

This PR updates PWA plugin, the custom Vite build not including envDir and envPrefix: Astro using PUBLIC_ prefix instead VITE_ (Vite default).

The PWA plugin 0.19.6 includes a custom function for integrations to allow update the Vite configuration for the custom sw build (integration.configureCustomSWViteBuild).

closes #42

@userquin userquin merged commit fb7ae4d into main Mar 21, 2024
@userquin userquin deleted the userquin/fix-astro-env branch March 21, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong environment prefix. It should be PUBLIC_ instead of VITE_
1 participant