fix: respect base to register dev service worker

vite-pwa · Mar 28, 2023 · e59f088 · e59f088
1 parent b37206a
commit e59f088
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/api.ts b/src/api.ts
@@ -104,7 +104,7 @@ export function createAPI(ctx: PWAPluginContext): VitePluginPWAAPI {
       let shouldRegisterSW = options.injectRegister === 'inline' || options.injectRegister === 'script'
       if (ctx.devEnvironment && ctx.options.devOptions.enabled === true) {
         type = ctx.options.devOptions.type ?? 'classic'
-        script = generateRegisterDevSW()
+        script = generateRegisterDevSW(ctx.options.base)
         shouldRegisterSW = true
       }
       else if (shouldRegisterSW) {

diff --git a/src/html.ts b/src/html.ts
@@ -63,9 +63,10 @@ export function generateRegisterSW(options: ResolvedVitePWAOptions, dev: boolean
   return undefined
 }
 
-export function generateRegisterDevSW() {
+export function generateRegisterDevSW(base: string) {
+  const path = `${base.endsWith('/') ? base : `${base}/`}${DEV_SW_VIRTUAL.slice(1)}`
   return `<script id="vite-plugin-pwa:register-dev-sw" type="module">
-import registerDevSW from '${DEV_SW_VIRTUAL}';
+import registerDevSW from '${path}';
 registerDevSW();
 </script>`
 }

diff --git a/src/plugins/dev.ts b/src/plugins/dev.ts
@@ -41,7 +41,7 @@ export function DevPlugin(ctx: PWAPluginContext): Plugin {
 
         return html.replace(
           '</body>',
-            `${generateRegisterDevSW()}
+            `${generateRegisterDevSW(options.base)}
 </body>`,
         )
       },