Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make manifest.shortcuts.icons optional #509

Closed
AntonOfTheWoods opened this issue May 4, 2023 · 0 comments · Fixed by #510
Closed

Make manifest.shortcuts.icons optional #509

AntonOfTheWoods opened this issue May 4, 2023 · 0 comments · Fixed by #510

Comments

@AntonOfTheWoods
Copy link
Contributor

For both https://web.dev/app-shortcuts/ and https://developer.mozilla.org/en-US/docs/Web/Manifest/shortcuts, icons are optional. They are currently mandatory when shortcuts are included.
AntonOfTheWoods added a commit to AntonOfTheWoods/vite-plugin-pwa that referenced this issue May 4, 2023
@AntonOfTheWoods
fix: Make manifest.shortcuts.icons optional vite-pwa#509
a343f23 
Signed-off-by: Anton Melser <anton.melser@outlook.com>
AntonOfTheWoods added a commit to AntonOfTheWoods/vite-plugin-pwa that referenced this issue May 4, 2023
@AntonOfTheWoods
fix: Make manifest.shortcuts.icons optional vite-pwa#509
5da3eea 
Fixes vite-pwa#509

Signed-off-by: Anton Melser <anton.melser@outlook.com>
@AntonOfTheWoods AntonOfTheWoods mentioned this issue May 4, 2023
Merged
userquin pushed a commit that referenced this issue May 13, 2023
@AntonOfTheWoods
fix: Make manifest.shortcuts.icons optional #509 (#510)
c59de75 
Fixes #509

Signed-off-by: Anton Melser <anton.melser@outlook.com>
@renovate renovate bot mentioned this issue May 29, 2023
Merged
1 task
greatuber pushed a commit to greatuber/vite-plugin-pwa that referenced this issue Apr 10, 2024
fix: Make manifest.shortcuts.icons optional #509 (#510)
3c76f9f 
Fixes vite-pwa/vite-plugin-pwa#509

Signed-off-by: Anton Melser <anton.melser@outlook.com>
sabugaa0128 added a commit to sabugaa0128/vite-plugin-pwa that referenced this issue Apr 11, 2024
@sabugaa0128
fix: Make manifest.shortcuts.icons optional #509 (#510)
ca06c1e 
Fixes vite-pwa/vite-plugin-pwa#509

Signed-off-by: Anton Melser <anton.melser@outlook.com>
HecateAkke added a commit to HecateAkke/vite-plugin-pwa that referenced this issue Apr 11, 2024
@HecateAkke
fix: Make manifest.shortcuts.icons optional #509 (#510)
0bcc0be 
Fixes vite-pwa/vite-plugin-pwa#509

Signed-off-by: Anton Melser <anton.melser@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make manifest.shortcuts.icons optional #509 AntonOfTheWoods/vite-plugin-pwa
1 participant
@AntonOfTheWoods