Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vite-preset-react #140

Merged
merged 3 commits into from Apr 10, 2021
Merged

Add vite-preset-react #140

merged 3 commits into from Apr 10, 2021

Conversation

PuruVJ
Copy link
Contributor

@PuruVJ PuruVJ commented Apr 5, 2021

Please make sure all the requirements are satisfied, otherwise the PR could be closed without further notice.

Checklist

  • Title as described.
  • Make sure you put things in the right category.
  • The description of your item should be a sentence with less than 24 words.
  • Omit unnecessary words already provided in the context (e.g. for Vite, a Vite plugin).
  • Always add your items to the end of a list.

Plugins/Tools

  • The plugin/tool is working with Vite 2.0 and onward.
  • The project is Open Source.
  • The project follows the Vite Plugins Conventions.
  • The repo should be at least 30 days old.
  • The documentation is in English.
  • The project is active and maintained.
  • The project accepts contributions.
  • Not a commercial product.

@patak-dev patak-dev changed the title Add vite-preset-vite Add vite-preset-react Apr 5, 2021
@PuruVJ
Copy link
Contributor Author

PuruVJ commented Apr 5, 2021

@antfu What do you think of this new General category? Is it Ok? Should I try something else?

@antfu
Copy link
Member

antfu commented Apr 5, 2021

Maybe Presets - and the link is 404

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Apr 5, 2021

Fixed it 😅

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Apr 5, 2021

@antfu is it ok now?

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Apr 8, 2021

Hi, Its been 3 days. Is there anything not right with this package that prohibits it from being merged into the repo? If so, I'll gladly close the PR.

Or I can wait if you're having a busy time, I understand.

@antfu
Copy link
Member

antfu commented Apr 9, 2021

Just doing this in batches, be a bit more patient, thanks

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Apr 9, 2021

No problem!!! take all the time you need 👍👍

@antfu antfu merged commit 14f518d into vitejs:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants