Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite-ecosystem-ci fail with vite 4.1 beta #111

Closed
patak-dev opened this issue Jan 25, 2023 · 3 comments
Closed

vite-ecosystem-ci fail with vite 4.1 beta #111

patak-dev opened this issue Jan 25, 2023 · 3 comments

Comments

@patak-dev
Copy link
Member

Hey @csr632, vite-plugin-react-pages is failing on Vite. See here. We are planning to request testing for beta.1 and then try to release it before Vue.js Amsterdam. If you can check if this is a regression, that would be really helpful. Thanks!

cc @dominikg

PS: Are you in https://chat.vitejs.dev? It would be easier to discuss these issues there.

@csr632 csr632 closed this as completed in 28692e5 Jan 25, 2023
@csr632
Copy link
Member

csr632 commented Jan 25, 2023

@patak-dev

The error caused by TS type changes between different rollup version (vite is bumping rollup version). This repo install rollup as it's own dependency and it's version is locked by lockfile, which is now different from the rollup version used by vite. Basically:

import type { UserConfig } from "vite";
import type { OutputPlugin } from "rollup"; // local rollup

const myRollupPlugin: OutputPlugin = {
  // ...
} as any;

const viteConfig: UserConfig = {
  build: {
    rollupOptions: {
      output: {
        manualChunks: undefined,
        // local rollup's types may not be compatible with vite's rollup types
        plugins: [myRollupPlugin],
      },
    },
  },
};

It should be fixed now. Could you try again?

@patak-dev
Copy link
Member Author

Thanks for the quick fix! It is working now. Here is the run

@csr632
Copy link
Member

csr632 commented Jan 25, 2023

PS: Are you in https://chat.vitejs.dev/? It would be easier to discuss these issues there.

Yeah I just joined the chat. But I don't open discord regularly. Please remind me on Github if I miss something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants