Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add defineModel and propsDestructure options #173

Closed
wants to merge 9 commits into from
Closed

fix: add defineModel and propsDestructure options #173

wants to merge 9 commits into from

Conversation

so1ve
Copy link

@so1ve so1ve commented May 11, 2023

Description

Add types for defineModel macro and reactive props destructure.

close #161

Additional context

https://blog.vuejs.org/posts/vue-3-3


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

(add test cases soon)

@so1ve
Copy link
Author

so1ve commented May 11, 2023

Not sure about how to test defineModel..

@so1ve so1ve changed the title feat: support defineModel macro and propsDestructure fix: add defineModel and propsDestructure options May 11, 2023
@yyx990803
Copy link
Member

The RFCs and types have been updated to allow passing the options under script, I don't think we need top-level options anymore. Still open to testing these options in the playground though.

@so1ve
Copy link
Author

so1ve commented May 12, 2023

Agreed. Closing

@so1ve so1ve closed this May 12, 2023
@so1ve so1ve deleted the feat/definemodel-propdestructure branch May 12, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propsDestructure option support
3 participants