Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upgrade node version #237

Merged
merged 1 commit into from
Aug 28, 2023
Merged

ci: upgrade node version #237

merged 1 commit into from
Aug 28, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Aug 22, 2023

Description

  • Upgrade Node to the latest LTS for linting and publishing.
  • Add Node 20 for unit tests.
  • Upgrade Node to 18 for other OSs.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz requested a review from sodatea August 22, 2023 03:28
@sxzz sxzz merged commit b8dbcb4 into main Aug 28, 2023
8 checks passed
@sxzz sxzz deleted the ci/node branch August 28, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodatea sodatea Awaiting requested review from sodatea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sxzz