fix(plugin-vue): handle circular references in HMR check #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NateScarlet
changed the title
Maximum call stack size exceeded (fix #325)Maximum call stack size exceeded (fix #325)
NateScarlet
force-pushed
the
fix/issue-325
branch
from
4f57db8
to
e7a7597
Compare
NateScarlet
force-pushed
the
fix/issue-325
branch
from
d1f6082
to
aeefa41
Compare
sodatea
requested changes
Jan 8, 2024
There was a problem hiding this comment.
Could you add a test case for this bug in https://github.com/vitejs/vite-plugin-vue/blob/main/playground/vue/__tests__/vue.spec.ts#L173 ?
This comment was marked as resolved.
This comment was marked as resolved.
sodatea
approved these changes
Jan 9, 2024
sodatea
changed the title
Maximum call stack size exceeded (fix #325)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handle circular reference in
deepEqualfixes #325
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).