Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: "absolute import" test case bug (fix #86) #87

Merged
merged 1 commit into from
Feb 14, 2023
Merged

test: "absolute import" test case bug (fix #86) #87

merged 1 commit into from
Feb 14, 2023

Conversation

mkrti-ch
Copy link
Contributor

@mkrti-ch mkrti-ch commented Jan 12, 2023 •
edited

Description

Fixing little bug in test case described in #86

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red changed the title fix: "absolute import" test case bug (fix #86) test: "absolute import" test case bug (fix #86) Jan 16, 2023
sapphi-red
sapphi-red approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red linked an issue Jan 16, 2023 that may be closed by this pull request
"absolute import" test has wrong selector #86
Closed
9 tasks
@sapphi-red sapphi-red merged commit b303656 into vitejs:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p1-chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"absolute import" test has wrong selector
2 participants
@mkrti-ch @sapphi-red