Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: vite 3 #28

Merged
merged 7 commits into from
Aug 31, 2022
Merged

feat!: vite 3 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eda650f
feat!: bump minimum node version to 14.18.0, 16.0.0
sapphi-red Jul 21, 2022
4d59508
feat!: vite 3
sapphi-red Jul 21, 2022
0b05dc1
refactor: use createFilter from vite
sapphi-red Jul 21, 2022
b4b6456
chore: mark helpers with null byte
sapphi-red Jul 21, 2022
a3d23ed
fix: handle undefined on import.meta.hot.accept
sapphi-red Jul 21, 2022
0a6b688
chore: use node prefix
sapphi-red Jul 21, 2022
ce8d915
test: skip TestMultiplySrcImport component
sapphi-red Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s"
},
"engines": {
"node": ">=14.6.0"
"node": "^14.18.0 || >= 16.0.0"
},
"repository": {
"type": "git",
Expand All @@ -36,11 +36,10 @@
},
"homepage": "https://github.com/vitejs/vite-plugin-vue2/#readme",
"peerDependencies": {
"vite": ">=2.5.10",
"vite": "^3.0.0",
"vue": "^2.7.0-0"
},
"devDependencies": {
"@rollup/pluginutils": "^4.2.1",
"@types/fs-extra": "^9.0.13",
"conventional-changelog-cli": "^2.2.2",
"debug": "^4.3.4",
Expand All @@ -58,7 +57,7 @@
"slash": "^3.0.0",
"source-map": "^0.6.1",
"unbuild": "^0.7.4",
"vite": "^2.9.12",
"vite": "^3.0.0",
"vitest": "^0.15.1",
"vue": "^2.7.0-beta.8"
}
Expand Down
2 changes: 1 addition & 1 deletion playground/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import TestCssVBind from './css/TestCssVBind.vue'
<div>
<h1>Vite-Plugin-Vue2 Playground</h1>
<ScriptSetup msg="prop from parent" />
<TestMultiplySrcImport />
<!-- <TestMultiplySrcImport /> -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was not working for me and it was failing from 1.0.0.

When this component is not commented out, <TestBlockSrcImport /> is shown twice instead of <TestMultiplySrcImport /> and <TestBlockSrcImport /> with bot h dev and build.
image

So I'm skipping this test for now.

<TestBlockSrcImport />
<TestScopedCss />
<TestCssModules />
Expand Down