fix(optimizer): let esbuild resolve transitive deps

fix #2199
vitejs · Feb 24, 2021 · 0138ef3 · 0138ef3
1 parent e5324ca
commit 0138ef3
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/packages/vite/src/node/optimizer/esbuildDepPlugin.ts b/packages/vite/src/node/optimizer/esbuildDepPlugin.ts
@@ -2,7 +2,12 @@ import path from 'path'
 import { Loader, Plugin } from 'esbuild'
 import { KNOWN_ASSET_TYPES } from '../constants'
 import { ResolvedConfig } from '..'
-import { isRunningWithYarnPnp, flattenId, normalizePath } from '../utils'
+import {
+  isRunningWithYarnPnp,
+  flattenId,
+  normalizePath,
+  isBuiltin
+} from '../utils'
 import { browserExternalId } from '../plugins/resolve'
 import { ExportsData } from '.'
 
@@ -97,18 +102,15 @@ export function esbuildDepPlugin(
             return entry
           }
 
-          // use vite resolver
-          const resolved = await resolve(id, importer)
-          if (resolved) {
-            if (resolved.startsWith(browserExternalId)) {
+          // externalize node built-ins
+          if (isBuiltin(id)) {
+            const resolved = await resolve(id, importer)
+            if (resolved && resolved.startsWith(browserExternalId)) {
               return {
                 path: id,
                 namespace: 'browser-external'
               }
             }
-            return {
-              path: path.resolve(resolved)
-            }
           }
         }
       )