fix: dymamic import polyfill path when base is a URL (#3132)

vitejs · Apr 25, 2021 · 02ba4ba · 02ba4ba
1 parent 0e7125a
commit 02ba4ba
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/packages/vite/src/node/plugins/dynamicImportPolyfill.ts b/packages/vite/src/node/plugins/dynamicImportPolyfill.ts
@@ -5,14 +5,24 @@ import path from 'path'
 
 export const polyfillId = 'vite/dynamic-import-polyfill'
 
+function resolveModulePath(config: ResolvedConfig) {
+  const {
+    base,
+    build: { assetsDir }
+  } = config
+  // #2918 path.posix.join returns a wrong path when config.base is a URL
+  if (/^(https?:)?(\/\/)/i.test(base)) {
+    return `${base.replace(/\/$/, '')}/${assetsDir}/`
+  }
+  return path.posix.join(base, assetsDir, '/')
+}
+
 export function dynamicImportPolyfillPlugin(config: ResolvedConfig): Plugin {
   const skip = config.command === 'serve' || config.build.ssr
   let polyfillLoaded = false
   const polyfillString =
     `const p = ${polyfill.toString()};` +
-    `${isModernFlag}&&p(${JSON.stringify(
-      path.posix.join(config.base, config.build.assetsDir, '/')
-    )});`
+    `${isModernFlag}&&p(${JSON.stringify(resolveModulePath(config))});`
 
   return {
     name: 'vite:dynamic-import-polyfill',